javascript link isn't working on click; function works when page loads -

javascript link isn't working on click; function works when page loads -

var randomnumber // generate random numbers based on length of image array randomnumber = math.floor(math.random() * topimages.length); function shuffletop(){ document.getelementbyid("topimage").src = topimages[randomnumber]; }; $("p a#shuffle").click(shuffletop());

this link in source code:

<p><a href="#" id="shuffle">shuffle</a></p>

you running function , returning beingness assigned cliek. not assigning reference function shuffletop.

$("p a#shuffle").click(shuffletop());

needs be

$("p a#shuffle").click(shuffletop);

and generate number once, move random number generator inside.

function shuffletop(){ randomnumber = math.floor(math.random() * topimages.length); document.getelementbyid("topimage").src = topimages[randomnumber]; };

javascript function random shuffle